Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory/cgroup fields to metricbeat Kibana module #37232

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add memory/cgroup fields to metricbeat Kibana module #37232

merged 2 commits into from
Nov 30, 2023

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Nov 29, 2023 •
edited
Loading

This PR updates the Metricbeat kibana module with support for the new memory and cgroup fields added to Kibana in elastic/kibana#172146. We plan to use this metric for serverless monitoring, so metricbeat needs to know about it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

- module: kibana
  metricsets:
    - stats # be sure to enable stats metricset
  period: 10s
  hosts: ["localhost:5601"]
  basepath: "abc" # whatever your base path is
  username: "elastic"
  password: "changeme"
  • ./metricbeat -e
  • create metricbeat-* data view in kibana
  • you should now be seeing some log entries which contain the new fields, eg. process.memory.array_buffers
Screenshot 2023-11-30 at 13 29 41

@pgayvallet pgayvallet added backport-skip Skip notification from the automated backport with mergify Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring >enhancement Team:Core labels Nov 29, 2023
@pgayvallet pgayvallet requested a review from a team as a code owner November 29, 2023 14:09
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2023
@pgayvallet pgayvallet removed needs_team Indicates that the issue/PR needs a Team:* label Team:Core labels Nov 29, 2023
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Duration: 6 min 15 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pgayvallet
Copy link
Contributor Author

run elasticsearch-ci/docs

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 50 min 43 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Nov 30, 2023 •
edited
Loading

My understanding was the Serverless uses Elastic Agent only and not Metricbeat directly?
If that's correct, could this not be added directly to the Kibana Integration instead and only there?
If it's needed for both Metricbeat and Elastic Agent, we'll need to also update the integrations mappings.

Further, will users on ESS or on-prem using the X-pack mode want these fields to be indexed as well?
In that case we need to update the mappings used for the X-pack mode as well.

miltonhultgren
miltonhultgren approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes themselves look correct

This was referenced Nov 30, 2023
Merged
Merged
@pgayvallet pgayvallet merged commit 20ee67c into elastic:main Nov 30, 2023
27 checks passed
@pgayvallet pgayvallet mentioned this pull request Nov 30, 2023
Closed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@pgayvallet @Scholar-Li
Add memory/cgroup fields to metricbeat Kibana module (elastic#37232)
3d1c1ae 
* Add memory/cgroup fields to metricbeat Kibana module

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

@pgayvallet pgayvallet

Labels
backport-skip Skip notification from the automated backport with mergify >enhancement Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgayvallet @elasticmachine @miltonhultgren